Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-coin-rune): new coin generation and SDK statics #4961

Closed
wants to merge 4 commits into from

Conversation

bhavidhingra
Copy link
Contributor

TICKET: WIN-3550

@bhavidhingra bhavidhingra requested review from a team as code owners September 27, 2024 13:21
@bhavidhingra bhavidhingra changed the title feat(sdk-coin-rune): new coin generation feat(sdk-coin-rune): new coin generation and SDK statics Sep 27, 2024
let basecoin;

before(function () {
bitgo.initializeTestVars();

Check failure

Code scanning / CodeQL

Property access on null or undefined

The base expression of this property access is always undefined.

before(function () {
bitgo.initializeTestVars();
basecoin = bitgo.coin('trune');

Check failure

Code scanning / CodeQL

Property access on null or undefined

The base expression of this property access is always undefined.
});

it('should instantiate the coin', function () {
const basecoin = bitgo.coin('trune');

Check failure

Code scanning / CodeQL

Property access on null or undefined

The base expression of this property access is always undefined.
Copy link
Contributor

@ajays97 ajays97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flushing from the queue, please re request after fixing checks.

Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not ready for review

@zahin-mohammad zahin-mohammad marked this pull request as draft September 30, 2024 23:19
@at31416 at31416 force-pushed the WIN-3550-thorchain-sdk-statics branch from 5d9d551 to eeb955b Compare October 9, 2024 03:00
@mohitkh7
Copy link
Contributor

Changes merged in PR: #5030

@mohitkh7 mohitkh7 closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants